Skip to content

Commit

Permalink
values: rename invenio.extraConfig
Browse files Browse the repository at this point in the history
* Renames invenio.extra_config to invenio.extraConfig to follow helm's
  naming conventions. Both variables are loaded for the moment to avoid
  issues. It also add a deprecation notice inside Notes.txt
  • Loading branch information
egabancho authored and lindhe committed Dec 5, 2024
1 parent 9cb7d37 commit 473243a
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 4 deletions.
12 changes: 11 additions & 1 deletion charts/invenio/templates/NOTES.txt
Original file line number Diff line number Diff line change
@@ -1 +1,11 @@
Invenio is ready to rock 🚀
Invenio is ready to rock 🚀

Your release is named {{ .Release.Name }}.

{{- if .Values.invenio.extra_config}}

DEPRECATION WARNING:
`invenio.extra_config` has been renamed to `invenio.extraConfig` and will be
removed in a future release.

{{- end }}
5 changes: 4 additions & 1 deletion charts/invenio/templates/invenio-configmap.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,8 @@ data:
INVENIO_DATACITE_ENABLED: "False"
INVENIO_LOGGING_CONSOLE_LEVEL: "WARNING"
{{- range $key, $value := .Values.invenio.extra_config }}
{{ $key }}: {{ tpl $value $ | toYaml | indent 5 | trim }}
{{ $key }}: {{ $value | toYaml | indent 4 | trim }}
{{- end }}
{{- range $key, $value := .Values.invenio.extraConfig }}
{{ $key }}: {{ tpl $value $ | toYaml | indent 4 | trim }}
{{- end }}
6 changes: 4 additions & 2 deletions charts/invenio/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,11 @@ invenio:
- name: ""
consumer_key: ""
consumer_secret: ""
## @param invenio.extra_config Extra environment variables (templated) to be added to all the pods.
##
## @param invenio.extra_config DEPRECATED: invenio.extraConfig instead
extra_config: {}
## @param invenio.extraConfig Extra environment variables (templated) to be added to all the pods.
##
extraConfig: {}
extra_env_from_secret: []
# - name: NAME_OF_MY_ENV_VAR
# valueFrom:
Expand Down

0 comments on commit 473243a

Please sign in to comment.