Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reset Mapping button in controllers config menu #651

Merged
merged 13 commits into from
Mar 14, 2024

Conversation

3alTemp
Copy link
Contributor

@3alTemp 3alTemp commented Jan 10, 2024

Description

As suggested by @komasio71, this implements a "reset" button in the "Configure X" menus that sets your button mappings to their default values. That's it.

2024-01-09.15-34-40.mp4

image
image
image

I don't think this requires much explanation; it assists you on wiping your button binds in case you set them to something silly and non-functional, if you're not happy with your current binds, or literally any other reason on which you would need to clear them out. Not a big change but it would be appreciated by tons of people and controllers alike :).

EFRO NOTE:

This change has raw text strings, so having new translatable lines would be very much appreciated!

Now, look at this very cool table telling you this is a new feature:

Type
✨ New feature

@3alTemp 3alTemp changed the title Reset Mapping button in controller's config menu Reset Mapping button in controllers config menu Jan 10, 2024
@komasio71
Copy link
Contributor

my idea!! :D (this comment was supposed to be posted a week now but anyway)

@3alTemp
Copy link
Contributor Author

3alTemp commented Jan 25, 2024

I'm too tired to change the whole input reset ordeal into another file, efro please just add your magical # pylint: disable=too-many-lines if you agree...

@efroemling
Copy link
Owner

This is a great addition; thanks! My one bit of feedback would be that I think the button should be a bit less prominent. I'd prefer to have 'Cancel' and 'Save' be the primary two actions users see. Could the reset button be a more muted color, smaller, and maybe tucked into the bottom or corner? Perhaps similar to the 'advanced' button in the controller window?..

@3alTemp
Copy link
Contributor Author

3alTemp commented Mar 2, 2024

This is a great addition; thanks! My one bit of feedback would be that I think the button should be a bit less prominent. I'd prefer to have 'Cancel' and 'Save' be the primary two actions users see. Could the reset button be a more muted color, smaller, and maybe tucked into the bottom or corner? Perhaps similar to the 'advanced' button in the controller window?..

Sure! I'll move the button to a corner real quick! (not as quick as I'll need to make sure it doesn't break on smaller UI sizes 🤠)

@efroemling
Copy link
Owner

Alternately I could see this also working as a menu entry under a '...' button. That would also give us a place to add any other functionality later (and the advanced button could go there too). Just a thought.

@3alTemp
Copy link
Contributor Author

3alTemp commented Mar 2, 2024

True, I'll follow to that and move them both in there.

@3alTemp
Copy link
Contributor Author

3alTemp commented Mar 2, 2024

Oh well, I'll leave the CI thing there; I've been trying to install it on VSC for a while, but it keeps plaguing the project with nonsensical Mypy(no-any-unimported) errors.

@efroemling
Copy link
Owner

Thanks for this!

@efroemling efroemling merged commit be7eb36 into efroemling:master Mar 14, 2024
16 checks passed
@3alTemp 3alTemp deleted the keybind_reset branch March 14, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants