CTF Ghost capturing fix 🚩 #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also I just noticed it once passed CI and then it fell back into not passing... Thank you typing extensions grr 😡 ... |
|
Thanks for the fix(es)! Though it makes me wonder if there'd be a better way to wire up flag behavior in the future that wouldn't require corner-case fixes like this. |
|
Quick heads-up related to this PR: I just checked in what I believe will fix it: f6f9526 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I picked up GitHub again and decided to make this pr again, which fixes a long-lived capture the flag bug [as seen on BSE!] which allowed players to recover their flags by dying or leaving the game while on them.
Bug footage: https://youtu.be/npJ4ePCkRGI
Fix footage: https://youtu.be/bZ53pd4o4Ic
Is there a better way to display >10mb videos in GitHub? Please let me know.
Type of Changes