Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix types on ESM #5

Closed
wants to merge 1 commit into from
Closed

Fix types on ESM #5

wants to merge 1 commit into from

Conversation

wladpaiva
Copy link

In certain cases you need to reexxport the types with the module

Screenshot 2024-10-27 at 11 23 15

@YuriRDev
Copy link

A small PR that resolved this annoying issue, please someone merge this 🙏🙏

@wladpaiva
Copy link
Author

3 weeks and no one even looked into this. Tbh I don't think efipay folks are really that open source friendly so if you got to here and are struggling with this issue, I recommend you patch the package with the patch-package

diff --git a/node_modules/sdk-node-apis-efi/package.json b/node_modules/sdk-node-apis-efi/package.json
index c02b697..6d2d168 100755
--- a/node_modules/sdk-node-apis-efi/package.json
+++ b/node_modules/sdk-node-apis-efi/package.json
@@ -5,7 +5,8 @@
 	"exports": {
 		".": {
 			"require": "./dist/cjs/index.cjs",
-			"import": "./dist/cjs/index.cjs"
+			"import": "./dist/cjs/index.cjs",
+			"types": "./dist/types/index.d.ts"
 		}
 	},
 	"description": "Module for integration with Efi Bank API",

@joao-muniz-efi
Copy link
Member

Hello, @wladpaiva and @YuriRDev. First of all, I hope that you're doing well. We thank you, @wladpaiva for the contribution, and we inform that we will include this change in the next version, that will be released now.

@joao-muniz-efi
Copy link
Member

@wladpaiva your solution was implemented in https://github.com/efipay/sdk-node-apis-efi/releases/tag/1.2.9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants