JiraInstanceManagerRest.groovy (#50)

* Improving error handling in executeLocalScriptFile()
eficode · Apr 2, 2024 · 0c58fba · 0c58fba
1 parent b2c298a
commit 0c58fba
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/pom.xml b/pom.xml
@@ -6,7 +6,7 @@
 
     <groupId>com.eficode.atlassian</groupId>
     <artifactId>jirainstancemanager</artifactId>
-    <version>2.1.3</version>
+    <version>2.1.4</version>
     <description>A groovy library for interacting with Jira REST API.</description>
 
     <properties>
@@ -74,7 +74,7 @@
         <dependency>
             <groupId>org.apache.groovy</groupId>
             <artifactId>groovy-json</artifactId>
-            <version>4.0.8</version>
+            <version>${groovy.version}</version>
         </dependency>
         <dependency>
             <groupId>net.lingala.zip4j</groupId>

diff --git a/src/main/groovy/com/eficode/atlassian/jiraInstanceManager/JiraInstanceManagerRest.groovy b/src/main/groovy/com/eficode/atlassian/jiraInstanceManager/JiraInstanceManagerRest.groovy
@@ -1795,7 +1795,12 @@ final class JiraInstanceManagerRest {
 
         HttpResponse scriptResponse = rest.post("/rest/scriptrunner/latest/user/exec/").connectTimeout(4 * 60000).cookie(acquireWebSudoCookies()).contentType("application/json").body(["script": scriptContent]).asJson()
 
-        Map scriptResponseJson = scriptResponse.body.getObject().toMap()
+        Map scriptResponseJson = scriptResponse.body?.getObject()?.toMap()
+
+        if (!scriptResponseJson) {
+            log.warn("Error getting response after executing ScriptRunner Script, got body:" + scriptResponse.body?.toPrettyString())
+        }
+
         ArrayList<String> logRows = scriptResponseJson.snapshot?.log?.split("\n")
         ArrayList<String> errorRows = scriptResponseJson.errorMessages