Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ported Cortex e2e modules, so we can reuse it smaller projects too. #5

Merged
merged 2 commits into from
Mar 26, 2021

Conversation

bwplotka
Copy link
Contributor

For awareness: @praccuci @pstibrany @kakkoyun porting our amazing integration suite to separate module. I cleaned this a little bit to make sure we import only minimum deps (see go.mod), otherwise it's drop-in.

Happy to give you write perms to this lib. We can move it totally different repo with proper release versioning etc, but this is not the problem I want to fix. Rather: large dep tree ( want to use e2e in many other smaller projects) 🤗

PRs for Cortex and Thanos to propose using it (feel free to close those if we don't want this) to come.

Signed-off-by: Bartlomiej Plotka [email protected]

@bwplotka bwplotka force-pushed the e2e branch 2 times, most recently from b0ecdf4 to aaf4f0c Compare January 29, 2021 20:57
Signed-off-by: Bartlomiej Plotka <[email protected]>
@kakkoyun
Copy link

kakkoyun commented Feb 1, 2021

Maybe we can create a corthanos organization for the shared dependencies?

@bwplotka
Copy link
Contributor Author

bwplotka commented Feb 4, 2021

Very fair point. I already created shared org corthanos. We could also put it in prometheus-community or something.

@bwplotka
Copy link
Contributor Author

I think there is low motivation to spread the maintenance burden to separate repos as @praccuci mentioned. Some other option is to put this in Cortex in separate go.mod

@bwplotka
Copy link
Contributor Author

Also looks like Thanos Team does not want rest of those tools (e.g testutil) to be depending on in Thanos, so I think I would just copy it here and syncing manually, we could the same with this framework

Copy link

@pracucci pracucci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bwplotka for considering the e2e framework! I haven't deeply reviewed changes but I'm approving to mention I'm 💯 fine picking up the e2e framework we collaboratively worked on Cortex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants