env_kind.go: load image into kind cluster #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit load the image into the kind cluster with ``` kind load docker-image <image-name> ``` We need to do this if the image is not in a public registry. Honestly, the purpose of the `preLoadImage()` function is not clear to me. Signed-off-by: leonnicolas <[email protected]>
leonnicolas
commented
Nov 18, 2024
env_kind.go
Outdated
Comment on lines
769
to
771
| if _, err = r.env.execContext(ctx, "docker", "image", "inspect", r.opts.Image).CombinedOutput(); err == nil { | ||
| return nil | ||
| return r.loadImageIntoKindCluster(ctx) | ||
| } |
There was a problem hiding this comment.
Actually this won't work for a public image that is not present on the machine, yet.
I feel like we should remove the if block. The comment in line 774/773 suggests that we should pull the image if we get an "No such image" error, but pulling an image that does no have a manifest will never work.
So rather we should either
a. check if the image is present locally and if not try to pull it and finally (always) load it into docker
b. check if image is present locally. If yes do nothing more. If no check if it is present locally and load it into kind or fail.
Pull only the image if it isn't present on the machine and always load it into the cluster.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit load the image into the kind cluster with
We need to do this if the image is not in a public registry.
It also stops using
docker manifest inspect.Instead we should rather check if the image is present locally.
If so we can load it into the cluster, otherwise we have to pull it first.
Signed-off-by: leonnicolas [email protected]