Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to disable cadvisor #56

Merged
merged 2 commits into from
Nov 18, 2022
Merged

Conversation

utukJ
Copy link
Contributor

@utukJ utukJ commented Nov 1, 2022

Added option to disable cadvisor when starting e2e monitoring.
#55

Copy link
Collaborator

@matej-g matej-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @utukJ!

monitoring/monitoring.go Outdated Show resolved Hide resolved
Copy link
Contributor

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just minor nit. Thanks!

monitoring/monitoring.go Outdated Show resolved Hide resolved
monitoring/monitoring.go Outdated Show resolved Hide resolved
monitoring/monitoring.go Outdated Show resolved Hide resolved
Copy link
Contributor

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@bwplotka bwplotka merged commit 861932b into efficientgo:main Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants