Modularize travis #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great! So the PR also only builds the folders for the given language that corresponds to the current We should cache base OCaml (4.03.0) definitely. But we should build Multicore OCaml from scratch to make sure the examples work with trunk. |
Yes, you can see that in the output of the build matrix: https://travis-ci.org/effect-handlers/effects-rosetta-stone/builds/377719375?utm_source=github_status&utm_medium=notification |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #5 by @kayceesrk, I started modularizing the travis build by explicitly listing all programming languages in the build matrix. The environment variable
PROGLANGis used to only select the folder of the corresponding language in the make file.Here is a a build job using this config.
@kayceesrk Could you review the ocaml setup? Is it really necessary to build ocaml every time? Can we cache this?