Skip to content

Commit

Permalink
Fix stale configuration documentation. (apache#1257)
Browse files Browse the repository at this point in the history
  • Loading branch information
efeg authored and Adem Efe Gencer committed Jul 8, 2020
1 parent e6a1347 commit c85eb6e
Show file tree
Hide file tree
Showing 3 changed files with 165 additions and 165 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,7 @@ private AnomalyDetectorConfig() {
*/
public static final String ANOMALY_NOTIFIER_CLASS_CONFIG = "anomaly.notifier.class";
public static final String DEFAULT_ANOMALY_NOTIFIER_CLASS = NoopNotifier.class.getName();
public static final String ANOMALY_NOTIFIER_CLASS_DOC = "The notifier class to trigger an alert when an "
+ "anomaly is violated.";
public static final String ANOMALY_NOTIFIER_CLASS_DOC = "The notifier class to trigger an alert when an anomaly is violated.";

/**
* <code>anomaly.detection.goals</code>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -303,14 +303,16 @@ private static boolean getBooleanExcludeGiven(HttpServletRequest request, String
}

/**
* Default: {@code false} -- i.e. a recently demoted broker may receive leadership from the other brokers.
* Default: {@code false} -- i.e. recently demoted brokers may receive leadership from the other brokers as long as
* {@link ExecutorConfig#DEMOTION_HISTORY_RETENTION_TIME_MS_CONFIG}.
*/
static boolean excludeRecentlyDemotedBrokers(HttpServletRequest request) {
return excludeBrokers(request, EXCLUDE_RECENTLY_DEMOTED_BROKERS_PARAM, false);
}

/**
* Default: {@code true} -- i.e. a recently removed broker may receive replicas from the other brokers.
* Default: {@code true} -- i.e. recently removed brokers may not receive replicas from the other brokers as long as
* {@link ExecutorConfig#REMOVAL_HISTORY_RETENTION_TIME_MS_CONFIG}.
*/
static boolean excludeRecentlyRemovedBrokers(HttpServletRequest request) {
return excludeBrokers(request, EXCLUDE_RECENTLY_REMOVED_BROKERS_PARAM, true);
Expand Down
Loading

0 comments on commit c85eb6e

Please sign in to comment.