[BUGFIX beta] Fix top-level non-default outlet disconnection

This resolves the secondary issue reported in [a comment](emberjs#10416 (comment)) on issue emberjs#10416.
ef4 · Feb 12, 2015 · c0a8c98 · c0a8c98
1 parent a60f255
commit c0a8c98
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 1 deletion.
diff --git a/packages/ember-routing/lib/system/route.js b/packages/ember-routing/lib/system/route.js
@@ -1845,6 +1845,7 @@ var Route = EmberObject.extend(ActionHandler, Evented, {
   disconnectOutlet: function(options) {
     var outletName;
     var parentView;
+    var parent;
     if (!options || typeof options === "string") {
       outletName = options;
     } else {
@@ -1853,7 +1854,8 @@ var Route = EmberObject.extend(ActionHandler, Evented, {
     }
 
     parentView = parentView && parentView.replace(/\//g, '.');
-    if (parentView === parentRoute(this).routeName) {
+    parent = parentRoute(this);
+    if (parent && parentView === parent.routeName) {
       parentView = undefined;
     }
     outletName = outletName || 'main';

diff --git a/packages/ember/tests/routing/basic_test.js b/packages/ember/tests/routing/basic_test.js
@@ -3500,6 +3500,38 @@ QUnit.test("Can render into a named outlet at the top level", function() {
   equal(Ember.$('#qunit-fixture').text(), "A-The index-B-Hello world-C", "initial render");
 });
 
+QUnit.test("Can disconnect a named outlet at the top level", function() {
+  Ember.TEMPLATES.application = compile("A-{{outlet}}-B-{{outlet \"other\"}}-C");
+  Ember.TEMPLATES.modal = compile("Hello world");
+  Ember.TEMPLATES.index = compile("The index");
+
+  registry.register('route:application', Ember.Route.extend({
+    renderTemplate: function() {
+      this.render();
+      this.render('modal', {
+        into: 'application',
+        outlet: 'other'
+      });
+    },
+    actions: {
+      banish: function() {
+        this.disconnectOutlet({
+          parentView: 'application',
+          outlet: 'other'
+        });
+      }
+    }
+  }));
+
+  bootApplication();
+
+  equal(Ember.$('#qunit-fixture').text(), "A-The index-B-Hello world-C", "initial render");
+
+  Ember.run(router, 'send', 'banish');
+
+  equal(Ember.$('#qunit-fixture').text(), "A-The index-B--C", "second render");
+});
+
 QUnit.test("Can render into a named outlet at the top level, with empty main outlet", function() {
   Ember.TEMPLATES.application = compile("A-{{outlet}}-B-{{outlet \"other\"}}-C");
   Ember.TEMPLATES.modal = compile("Hello world");