Change pattern of importing normalizeModelName
#4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change prevents this addon from breaking in consuming applications that are using Ember Data >= 2.14.0, where `ember-data/-private/system/normalize-model-name` is no longer available.
|
Thanks! |
|
Published in 0.0.8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change prevents this addon from breaking in consuming applications that
are using Ember Data >= 2.14.0, where
ember-data/-private/system/normalize-model-nameis no longer available. It appears as though it can simply be destructured from the top-level
DSobject instead.(This part of an Ember Data discussion might also lend a bit more insight.)
@ef4 It might also be useful to update the addon to the latest Ember CLI/Ember Data, but I wanted to leave that for a separate change.