You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks a lot for this plugin, it worked out-of-the-box for me, which is amazing given I’m still very new to Ember 👏
I wonder if we could add options so that the deploy would add a CNAME file with a custom domain, and optionally a 404.html which would be the same as index.html so that we don’t need the ENV.locationType = 'hash'; setting. It’s somewhat of a hack because the server responds with 404 status, but user’s don’t care, the app will still show
Happy to help with this if you point me to the right places. Or maybe there is a workaround for what I need? I’d greatly appreciate your help. Thanks!
The text was updated successfully, but these errors were encountered:
The CNAME file can go in your public directory and it should just work.
You can copy the built index.html to 404.html by extending your ember-cli-build.js file. I made a gist that shows how.
The copying step would make a fine standalone addon (implemented via postProcessTree). Alternatively, it could be done as an ember-cli-deploy plugin. In either case I think it's good to keep it separate from this addon because copying is a general-purpose need that other deploy pipelines may want to share too.
LevelbossMike
added a commit
to effective-ember/ember-showcase
that referenced
this issue
Jun 8, 2020
Without a CNAME file we will need to set this manually through
settings again after a deployment - we can just add it to `public`
instead.
Reference:
ef4/ember-cli-deploy-git#5
Thanks a lot for this plugin, it worked out-of-the-box for me, which is amazing given I’m still very new to Ember 👏
I wonder if we could add options so that the deploy would add a CNAME file with a custom domain, and optionally a
404.html
which would be the same asindex.html
so that we don’t need theENV.locationType = 'hash';
setting. It’s somewhat of a hack because the server responds with 404 status, but user’s don’t care, the app will still showHappy to help with this if you point me to the right places. Or maybe there is a workaround for what I need? I’d greatly appreciate your help. Thanks!
The text was updated successfully, but these errors were encountered: