Improve quoted string flexibility #177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And also use double-quoted strings for strings with "'", which minimizes escaping
|
@eemeli, looks like checks failed not because of my changes |
eemeli
reviewed
Jul 4, 2020
|
Thanks for your review, I'll change the code according to your comments ASAP |
eemeli
requested changes
Jul 6, 2020
Co-authored-by: Eemeli Aro <[email protected]>
|
Thank you for your suggestions, it's much better now |
eemeli
approved these changes
Jul 8, 2020
|
Thank you @Himura2la! |
|
@eemeli thanks for merging this helpful option. When do you plan to make it available in npm? |
|
Sorry, missed your last comment. I'll try and get a |
|
@eemeli, just a friendly bump: we can't close a ticket in our system unless this PR is released. |
|
Sorry it took so long, but 2.0.0-0 is now finally out, including this fix. Release notes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use this library to update files, which are also updated by another (YamlDotNet) library, and we have quoting style not in sync, which generates useless changes. I added an option to choose the default quoting style, and also tried to avoid escaped single quotes within string content.