Switch browser build to use Rollup, drop @babel/runtime dependency #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, with Rollup the bundled library is _bigger_ if we leave in a runtime dependency on @babel/runtime. I don't know why.
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the nice things Rollup does is that given multiple entry points, it'll automatically dedupe all their dependencies. This allows the 70-ish source files of
yamlto be bundled into a much smaller number, which I figured might make it more bearable to bundle in the helpers that we've been getting from@babel/runtime.As it turns out, the final output is actually smaller with Rollup if the helpers are bundled in. I have no idea why. But everything still seems to work fine, even in IE 11. The current total minified, gzipped size of the library is about 56k.
To help with this, the various public entry points are now pointing to a much smaller set of re-exporters, rather than deep within the library.