Flow collections always wrap at >80 characters, regardless of lineWidth option

[TheBITLINK]

Describe the bug
When using the flow collection style, collections always seem to wrap at around 80 characters, regardless of the lineWidth option:

blockCollection:
  aKey: hello
  anotherKey: world
  yetAnotherKey: "!!!"
listOfFlowCollection:
  - {
      aKey: hello,
      anotherKey: world,
      yetAnotherKey: "!!!",
      oneMoreKey: "!!!!!!!!"
    }
  - {
      aKey: hello,
      anotherKey: world,
      yetAnotherKey: "!!!",
      oneMoreKey: "!!!!!!!!"
    }
flowColTwo:
  - { aKey: hello, bKey: world, cKey: "!!!" }
  - { aKey: hello, bKey: world, cKey: "!!!" }
  - { aKey: hello, bKey: world, cKey: "!!!", dKey: "!" }

To Reproduce

  function serialize() {
    const doc = new YAML.Document({
      blockCollection: {
        aKey: 'hello',
        anotherKey: 'world',
        yetAnotherKey: '!!!'
      },
      listOfFlowCollection: [
        { aKey: 'hello', anotherKey: 'world', yetAnotherKey: '!!!', oneMoreKey: '!!!!!!!!'  },
        { aKey: 'hello', anotherKey: 'world', yetAnotherKey: '!!!', oneMoreKey: '!!!!!!!!'  },
      ],
      flowColTwo: [
        { aKey: 'hello', bKey: 'world', cKey: '!!!'  },
        { aKey: 'hello', bKey: 'world', cKey: '!!!'  },
        { aKey: 'hello', bKey: 'world', cKey: '!!!',  dKey: '!' },
      ]
    })
    YAML.visit(doc, {
      Pair(_, pair: any) {
        if (pair.key?.value === 'listOfFlowCollection' || pair.key?.value === 'flowColTwo')  {
          for (const i of pair.value.items) {
            i.flow = true
          }
        }
      }
    })
    return doc.toString({ lineWidth: 120 })
  }

Expected behaviour
Flow collections respect the lineWidth option and wrap at 120 characters instead of 80 (or not wrap at all if lineWidth is 0)

blockCollection:
  aKey: hello
  anotherKey: world
  yetAnotherKey: "!!!"
listOfFlowCollection:
  - { aKey: hello, anotherKey: world, yetAnotherKey: "!!!", oneMoreKey: "!!!!!!!!" }
  - { aKey: hello, anotherKey: world, yetAnotherKey: "!!!", oneMoreKey: "!!!!!!!!" }
flowColTwo:
  - { aKey: hello, bKey: world, cKey: "!!!" }
  - { aKey: hello, bKey: world, cKey: "!!!" }
  - { aKey: hello, bKey: world, cKey: "!!!", dKey: "!" }

Versions (please complete the following information):

• Environment: Chrome 119.0.6045.159
• yaml: 2.3.4

Additional context
The same issue manifests when using collectionStyle: 'flow' in the toString() options, so it's not specific to mixed style.

[eemeli]

lineWidth isn't the option controlling this, but maybe it should be?

This is effectively a duplicate of #288, and there's an open issue #421 about improving the ergonomics of the solution.

[TheBITLINK]

Oh, cool, didn't know there was an internal value controlling that, only saw lineWidth in the documentation so I thought that would control this (it would make sense given the description of the property in the docs).

Not sure if lineWidth should control this as well, semantically it would make a lot of sense, but maybe there are people who want to control string length and flow width separately and there's always the weird edge cases on code already in production.

At the very least though, they should both be available in the options for toString() and the docs clarified to explain the differences.

[ben519]

Funny enough, I just stumbled my way here too. Fully expected doc.toString({ lineWidth: 120 }) to set the line width after reading the docs.

EDIT: My mistake.. The word wrapping was working as I expected. However, my editor was still wrapping text which game me the impression that lineWidth: 9999 wasn't working properly. My bad!

[eemeli]

A PR making lineWidth be used for flow collections instead of the current undocumented approach would be welcome.

[eemeli]

Fixed by #522.