Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connections returned from MockDataSource are not threadsafe #11

Closed
eeichinger opened this issue Jul 25, 2016 · 1 comment
Closed

Connections returned from MockDataSource are not threadsafe #11

eeichinger opened this issue Jul 25, 2016 · 1 comment
Labels
bug

Comments

@eeichinger
Copy link
Owner

eeichinger commented Jul 25, 2016 •
edited
Loading

Underlying MockRunner library reuses the same connection across all threads although the underlying implementations are not threadsafe. This violates JDBC API semantics and causes problems in integration test scenarios which use multiple thread / DataSource#getConnection() calls
@eeichinger eeichinger added the bug label Jul 25, 2016
eeichinger added a commit that referenced this issue Jul 25, 2016
@eeichinger
#11, wrap all Map and List instances in MockConnection with synchroni…
9847176 
…zed wrappers to avoid concurrent modification bugs
eeichinger added a commit that referenced this issue Jul 25, 2016
@eeichinger
Merge pull request #12 from eeichinger/concurrency_bug
d5cf8e4 
#11 fix concurrent modification problem in MockConnection
@eeichinger
Copy link
Owner Author

fix in #12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eeichinger