Allow for non-unit return types #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Guess I'm gonna need some assistance for the dotty part of this ^^ |
|
@Baccata Nice. Thanks for the contribution. The original // should have two type parameters; one for recorded type, another for returned type
// so far failed to implement the macro side of this |
done here : 7c9fbe7 |
|
@eed3si9n I've attempted fixing the dotty layer, but I'm a bit stuck : |
bishabosha
suggested changes
Jul 25, 2019
| inline def apply(recording: Boolean): Unit = | ||
| abstract class Recorder[R, A] { | ||
| def listener: RecorderListener[R, A] | ||
| inline def apply(recording: R): Unit = |
|
Awesome. Could you squash your commits please, and I think it's ready to merge. |
This adds input/output type parameters to the Recorder : * allows non boolean arguments to be captured * allow non-unit types to be returned The goal is to broaden the usage of this library, by letting people extend the Recoder class to potentially capture other types / return error-capable datatypes, etc
Baccata
force-pushed
the
allow-for-non-unit-return-types
branch
from
4122318 to
8e1daf7
Compare
|
Done in 8e1daf7 |
eed3si9n
approved these changes
Jul 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the internal API to allow to return some other types than Unit, so that people can use leverage the macro to declare their own assertion functions, returing Either/Try, etc.