Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update react & react-dom to v17 #291

Merged
merged 8 commits into from
Jul 5, 2023

Conversation

BilalQamar95
Copy link
Contributor

@BilalQamar95 BilalQamar95 commented Jun 8, 2023

Ticket

Upgrade React JS to v17

Description

  • Updated react & react-dom to v17, along with react-test-renderer to respective compatible versions
  • Since Enzyme does not provide support React 17 (enzymejs/enzyme#2429) or 18 (enzymejs/enzyme#2524) itself we switched to community-supported project that aim to provide compatibility between Enzyme and React 17, replacing enzyme-adapter-react-16 with @wojtekmaj/enzyme-adapter-react-17
  • Updated paragon to fix react-loading-skeleton issue

@BilalQamar95 BilalQamar95 self-assigned this Jun 8, 2023
@Mashal-m Mashal-m force-pushed the bilalqamar95/react-upgrade-to-v17 branch from 46a9383 to b3efee5 Compare June 14, 2023 11:38
@codecov-commenter
Copy link

codecov-commenter commented Jun 14, 2023

Codecov Report

Merging #291 (277c755) into master (0652dd2) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #291   +/-   ##
=======================================
  Coverage   89.61%   89.61%           
=======================================
  Files           8        8           
  Lines          77       77           
  Branches       11       11           
=======================================
  Hits           69       69           
  Misses          8        8           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Mashal-m Mashal-m force-pushed the bilalqamar95/react-upgrade-to-v17 branch from dac8f6a to 92d5a6f Compare June 21, 2023 06:49
@BilalQamar95 BilalQamar95 reopened this Jul 5, 2023
@BilalQamar95 BilalQamar95 reopened this Jul 5, 2023
@BilalQamar95 BilalQamar95 marked this pull request as ready for review July 5, 2023 06:39
@abdullahwaheed abdullahwaheed merged commit 662f583 into master Jul 5, 2023
@abdullahwaheed abdullahwaheed deleted the bilalqamar95/react-upgrade-to-v17 branch July 5, 2023 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants