Skip to content

Commit

Permalink
feat!: Rename ConfigWatcher app and configure as plugin; reduce fields (
Browse files Browse the repository at this point in the history
#485)

- ConfigWatcher needs to be configured as a plugin to be loaded into
  edxapp, since we don't use INSTALLED_APPS for this dependency.
- On the renaming: This is the name I actually meant to write in the
  first place.
- Remove some fields that are less likely to be interesting and are likely
  to just result in clutter.
  • Loading branch information
timmc-edx authored Oct 30, 2023
1 parent 25887c7 commit 4c1dda6
Show file tree
Hide file tree
Showing 5 changed files with 16 additions and 3 deletions.
9 changes: 9 additions & 0 deletions CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,15 @@ Change Log
Unreleased
~~~~~~~~~~

[3.0.0] - 2023-10-30
~~~~~~~~~~~~~~~~~~~~

Changed
_______

* Renamed ``ConfigWatcherApp`` to ``ConfigWatcher`` to be less redundant. This is technically a breaking change but the app was not in use yet.
* Enabled ``ConfigWatcher`` as a plugin for LMS

[2.2.0] - 2023-10-27
~~~~~~~~~~~~~~~~~~~~

Expand Down
2 changes: 1 addition & 1 deletion edx_arch_experiments/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,4 @@
A plugin to include applications under development by the architecture team at 2U.
"""

__version__ = '2.2.0'
__version__ = '3.0.0'
5 changes: 4 additions & 1 deletion edx_arch_experiments/config_watcher/apps.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,15 @@
from django.apps import AppConfig


class ConfigWatcherApp(AppConfig):
class ConfigWatcher(AppConfig):
"""
Django application to report configuration changes to operators.
"""
name = 'edx_arch_experiments.config_watcher'

# Mark this as a plugin app
plugin_app = {}

def ready(self):
from .signals import receivers # pylint: disable=import-outside-toplevel

Expand Down
2 changes: 1 addition & 1 deletion edx_arch_experiments/config_watcher/signals/receivers.py
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ def _report_waffle_delete(model_short_name, instance):
{
'model': waffle.models.Flag,
'short_name': 'flag',
'fields': ['everyone', 'percent', 'superusers', 'staff', 'authenticated', 'note', 'languages'],
'fields': ['everyone', 'percent', 'note'],
},
{
'model': waffle.models.Switch,
Expand Down
1 change: 1 addition & 0 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,7 @@ def is_requirement(line):
entry_points={
"lms.djangoapp": [
"arch_experiments = edx_arch_experiments.apps:EdxArchExperimentsConfig",
"config_watcher = edx_arch_experiments.config_watcher.apps:ConfigWatcher",
],
},
)

0 comments on commit 4c1dda6

Please sign in to comment.