test: Remove support for Node 18 #30
Conversation
Coverage report
This PR does not seem to contain any modification to coverable code. |
| @@ -63,8 +63,8 @@ WORKDIR ${INSIGHTS_CODE_DIR}/ | |||
| # insights service config commands below | |||
| RUN pip install --no-cache-dir -r ${INSIGHTS_CODE_DIR}/requirements/production.txt | |||
|
|
|||
| RUN nodeenv ${INSIGHTS_NODEENV_DIR} --node=18.20.2 --prebuilt \ | |||
| && npm install -g [email protected] | |||
| RUN nodeenv ${INSIGHTS_NODEENV_DIR} --node=20.15.1 --prebuilt \ | |||
There was a problem hiding this comment.
As the Dockerfile has been moved to public-dockerfiles repo, node20 change would be needed there. We can remove this change
There was a problem hiding this comment.
This Node 20 update is required because the PR drops support for Node 18, and the Dockerfile is still active in this project. There’s a separate PR to remove the Dockerfile, it’s pending due to CI failures, for now Dockerfile is still part of this project and utilized in CI, aligning it with the Node version specified in the PR is necessary to ensure compatibility and prevent CI failures. Once that PR is merged and the Dockerfile is gone this won't matter, until then for as long as Dockerfile continues to exist, this change is relevant and essential.
Part of openedx/public-engineering#230.
Description
Completed upgrade to Node 20 by removing the Node 18 CI check and using
.nvmrcfor version to use.See openedx/public-engineering#267 for further information.