fix: Disable mobile payment refunds from ecommerce #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christopappas
approved these changes
Sep 26, 2024
Comment on lines
90
to
91
| processor_responses = order.basket.paymentprocessorresponse_set.all() | ||
| return any(response.processor_name in MOBILE_PAYMENT_PROCESSORS |
There was a problem hiding this comment.
I suspect MOBILE_PAYMENT_PROCESSORS is fairly small, but I think iterating over the processor_responses variable will make 1 db call for each item (unless it had been prefetched ahead of time). You might consider doing something like order.basket.paymentprocessorresponse_set.filter(name__in= MOBILE_PAYMENT_PROCESSORS).exists() which I THINK might do it in 1 DB call (untested of course though)
Not a blocking comment by any means, but think it's worth thinking about potentially
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛔️ MAIN BRANCH WARNING! 2U EMPLOYEES must make branches against the 2u/main BRANCH
⛔️ DEPRECATION WARNING
This repository is deprecated and in maintainence-only operation while we work on a replacement, please see this announcement for more information.
Although we have stopped integrating new contributions, we always appreciate security disclosures and patches sent to [email protected]
Anyone internally merging to this repository is expected to release and monitor their changes; if you are not able to do this DO NOT MERGE, please coordinate with someone who can to ensure that the changes are released.
Required Testing
(^ We can remove that manual check once REV-2624 is done and the corresponding e2e test runs again)
Description
The process for mobile refunds follows a distinct flow that requires users to visit the relevant app store to receive their refunds. However, there are instances where the support team mistakenly processes refunds through the eCommerce platform, which is not the correct procedure. To address this, the eCommerce refund option for the support team is being disabled in this PR.
Useful information to include:
Supporting information
Jira Ticket: https://2u-internal.atlassian.net/browse/LEARNER-9948