Adopt ceil method for ios inapp prices #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -34,6 +34,9 @@ def create_ios_product(course, ios_product, configuration): | |||
| Create in app ios product on connect store. | |||
| return error message in case of failure. | |||
| """ | |||
| if course['price'] > 1000: | |||
| return 'Error: Appstore does not allow price> 1000' | |||
| if nearest_low_price < customer_price <= price: | ||
| nearest_low_price = customer_price | ||
| nearest_low_price_id = price_point['id'] | ||
| if nearest_high_price > customer_price >= price: |
There was a problem hiding this comment.
question: what is the scenario where price is greater than customer_price?
There was a problem hiding this comment.
customer price range is 0-1000 and we are already filtering > 1000 cases. Therefore there is no chance for this scenario.
Even if it occurs this function will return exception and we will not apply price for that product and will investigate issue afterwards.
| 'price': 1001 | ||
| } | ||
| error_msg = create_ios_product(course, self.ios_seat, self.configuration) | ||
| self.assertEqual(error_msg, 'Error: Appstore does not allow price> 1000') |
There was a problem hiding this comment.
price> 1000 should be price > 1000
| @@ -212,6 +212,7 @@ def record_processor_response(self, response, transaction_id=None, basket=None, | |||
| basket=basket) | |||
|
|
|||
| meta_data = self._get_metadata(currency_code=currency_code, price=price) | |||
| original_transaction_id = original_transaction_id or transaction_id | |||
There was a problem hiding this comment.
question: how does this change relate to the inapp price change?
There was a problem hiding this comment.
It doesn't. I noticed that nit and will be sending as a separate commit in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⛔️ MAIN BRANCH WARNING! 2U EMPLOYEES must make branches against the 2u/main BRANCH
⛔️ DEPRECATION WARNING
This repository is deprecated and in maintainence-only operation while we work on a replacement, please see this announcement for more information.
Although we have stopped integrating new contributions, we always appreciate security disclosures and patches sent to [email protected]
Anyone internally merging to this repository is expected to release and monitor their changes; if you are not able to do this DO NOT MERGE, please coordinate with someone who can to ensure that the changes are released.
Required Testing
(^ We can remove that manual check once REV-2624 is done and the corresponding e2e test runs again)
Description
Adopt ceil method for ios inapp prices i.e. pick closest higher price point for an inapp purchase. And if course price is > 1000 then don't apply price for this product.
Previously for android purchases we were not storing transaction ids in paymentresponseextension table, this change will also fix this issue.
For user cancelled payments return user cancelled error in execute api view.
Supporting information
Jira Ticket: https://2u-internal.atlassian.net/browse/LEARNER-10095