Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update README for 2U fork #25

Merged
merged 4 commits into from
Jul 16, 2024
Merged

docs: update README for 2U fork #25

merged 4 commits into from
Jul 16, 2024

Conversation

robrap
Copy link

@robrap robrap commented Jul 16, 2024


I've completed each of the following or determined they are not applicable:

  • Made a plan to communicate any major developer interface changes (or N/A)

README.rst Outdated Show resolved Hide resolved
Copy link
Author

@robrap robrap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing linting issues.

README.rst Outdated Show resolved Hide resolved
README.rst Outdated Show resolved Hide resolved

.. _Getting Started guide: https://edx.readthedocs.io/projects/open-edx-devstack/en/latest/getting_started.html
.. _Getting Started guide: https://github.com/edx/devstack/blob/master/docs/getting_started.rst
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for switching these URLs from the rendered docs to the source? Do we no longer have the ability to push to edx.readthedocs.io?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. That is for the Open edX version, which they don't plan on retiring, but they are going to put up a banner that points to this file. We could publish to read the docs at some point again, but that is future work that I am not taking on, so this README update just reflects the current reality.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the ticket for publishing to Read the Docs again: edx/edx-arch-experiments#578

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, thanks!

Copy link
Member

@timmc-edx timmc-edx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just may want to call out the RTD issue directly in the commit message.

@robrap robrap merged commit 18b554e into master Jul 16, 2024
5 checks passed
@robrap robrap deleted the robrap/update-readme branch July 16, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants