Use percentage for html font-size #188
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sets font-size for html to 93.75% instead of 15px, as using px for root font-size creates an accessibility issue by preventing users' default font sizes from being applied.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets
font-sizeforhtmlto93.75%instead of15px, as usingpxfor rootfont-sizecreates an accessibility issue by preventing users' default font sizes from being applied.The tradeoff for this approach is possible compatibility issues for third-party CSS, but I imagine anyone using Tufte CSS isn't looking to complicate their design anyway.
@joshwcomeau wrote a helpful article about the use of different size units w/r/t accessibility, in which he also provides other solutions to this, though I think the percentage would work just fine here without requiring a refactor.