Array Home work #2
Conversation
There was a problem hiding this comment.
I'm very impressed with this. Everything is correct and you have clearly thought carefully about what you have done. 💯 It's really good that you've been able to use filter and map correctly even though you weren't able to make it to the class on Saturday.
I've left a few comments in the code for your feedback.
👍
| function onClearAll() { | ||
| todos.length = 0; // we can Set the array length to zero | ||
| // or we can replace an array with an empty array todos = []; |
There was a problem hiding this comment.
It's good that you've considered multiple solutions!
|
|
||
| if (newTodoText.length < 4) { | ||
| //process.exit(1); |
There was a problem hiding this comment.
I think by now you must have discovered that this doesn't work in the browser. There are a number of differences between Node and web browser JS, as you'll find out later in the course.
| if (newTodoText.length < 4) { | ||
| //process.exit(1); | ||
| alert(newTodoText + " It should be more than 3 characters long "); |
There was a problem hiding this comment.
I like that you've used the alert function from later down in the exercise to solve a problem here too.
| } else { | ||
| todos[index] = "X " + todos[index]; | ||
| } //I think there will be a problem that we can't add new todo that starts with X because it |
There was a problem hiding this comment.
Absolutely right! It's always good to consider the unintended consequences of what you've been asked to do. Do you have any ideas for how we could make this better?
| alert( | ||
| todos.find(function(item) { | ||
| return !item.startsWith("X"); |
There was a problem hiding this comment.
This is the third time you have checked that a string starts with an X. What could you add to this code that would prevent you repeating yourself?
Hello Edward,
First I would thank you for this exercise ,it was really nice to use J.S next to Html and CSS
this my first time and i hope it will not be the last ,I tried to solve it , I have some confusion in using the methods i fell that some of them are the same so i am trying to read more about them to understand it better
I'll be waiting for your review
Regards
Maaly ,