Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2: Initial API #13

Merged
merged 155 commits into from
Sep 25, 2023
Merged

V2: Initial API #13

merged 155 commits into from
Sep 25, 2023

Conversation

jwijenbergh
Copy link
Collaborator

@jwijenbergh jwijenbergh commented Mar 20, 2023

This PR refactors the public API by exposing a JSON API instead of handing over C types. This greatly simplifies the codebase

Also fixes #3, #10, #12, #15

TODO:

  • Document API
  • Use an enum instead of "secure_internet", "institute_access", "custom_server"
  • Cleanup conversion functions in client package
  • Split types into several packages
  • Make tests pass

@jwijenbergh jwijenbergh marked this pull request as ready for review September 25, 2023 07:31
@jwijenbergh jwijenbergh merged commit 785dd2b into main Sep 25, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Client implementation accross files
2 participants