Common 2.0.1 integration #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dzolnai
commented
Jun 6, 2024
•
dzolnai
commented
- Updates the common library to 2.0.1
- Searching is now done through the library instead of being done on the Android side
- We now correctly clean up the connection in common
- Fixed a few minor bugs, and did quite some code cleanup due to features not being used anymore
This commit removes the local searching, since the common library will be doing that for us from now on. Also I removed the custom JSON [de]serializing code, since we do not need to cache the lists anymore. Because of these changes, we were able to clean up quite some code on the Android side
Adds the cleanup call, and fixes some incorrect 'disconnect' status notifications in the UI and backend. This was mostly due to the UI requesting a status update immediately from the ViewModel, which then triggered a status update with the disconnected state. Another issue was an incorrect VPN level to status mapping, where we incorrectly treated the 'no network' level as a disconnected state, while actually it was connecting.
dima-ko
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.