Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor BGP DT to use split dataplane #1

Conversation

leifmadsen
Copy link

No description provided.

@eduolivares
Copy link
Owner

@leifmadsen thanks a lot for adapting my PR/branch to the recent changes in dataplane configuration.

I think there is something missing: we need to split the following step into two steps, right?
https://github.com/eduolivares/architecture/blob/bgp-basic-config/automation/vars/default.yaml#L252

@leifmadsen
Copy link
Author

leifmadsen commented May 3, 2024

@leifmadsen thanks a lot for adapting my PR/branch to the recent changes in dataplane configuration.

I think there is something missing: we need to split the following step into two steps, right? https://github.com/eduolivares/architecture/blob/bgp-basic-config/automation/vars/default.yaml#L252

Ah nice catch. I didn't look at the automation directory for some reason. I'll have to check early next week if you don't get to it, but that does seem correct. The HCI VA I imagine has an example we can borrow from:

https://github.com/openstack-k8s-operators/architecture/blob/main/automation/vars/default.yaml#L27-L52

@eduolivares eduolivares merged commit d5821e8 into eduolivares:bgp-basic-config May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants