-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to override test suite configuration #16
Conversation
Hi Remi, just for your information, I will change the license of this repo to the BSD 2-clause license later today (see issue #15). So if we pull this request, it will fall under the new license. Is that okay with you? |
@aklomp yes BSD is fine for me (even if PHP License is fine, ok not perfect for non PHP project, but debian is wrong on this ;) |
I definitively don't understand why travis fails... it works locally.
|
This pull request looks sensible. I'm willing to merge it, as long as the Travis build passes and if you squash some of the fixup commits :) |
With the Travis error, it looks like one or both of the SMB_ constants is empty. It's strange because the code looks fine... |
Maybe try replacing the concatenation in sprintf("smb://%s/%s/lseektest.txt", SMB_HOST, SMB_SHARE); |
Got it \o/ |
Woah :) OK, I'll look into this pull request late this evening. Could you please quash your commits into a nice and small patchset? |
This seems more flexible for people wanting to test