Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to override test suite configuration #16

Closed
wants to merge 14 commits into from

Conversation

remicollet
Copy link
Contributor

This seems more flexible for people wanting to test

@aklomp
Copy link
Collaborator

aklomp commented Sep 2, 2015

Hi Remi, just for your information, I will change the license of this repo to the BSD 2-clause license later today (see issue #15). So if we pull this request, it will fall under the new license. Is that okay with you?

@remicollet
Copy link
Contributor Author

@aklomp yes BSD is fine for me (even if PHP License is fine, ok not perfect for non PHP project, but debian is wrong on this ;)

@remicollet
Copy link
Contributor Author

I definitively don't understand why travis fails... it works locally.

$ php -d extension=modules/libsmbclient.so /usr/local/bin/phpunit.phar -c tests/phpunit.xml -v
PHPUnit 4.8.6 by Sebastian Bergmann and contributors.
Runtime:    PHP 5.6.12
Configuration:  /work/GIT/libsmbclient-php/tests/phpunit.xml
.............................................
Time: 366 ms, Memory: 15,75Mb
OK (45 tests, 145 assertions)

@aklomp
Copy link
Collaborator

aklomp commented Sep 2, 2015

This pull request looks sensible. I'm willing to merge it, as long as the Travis build passes and if you squash some of the fixup commits :)

@aklomp
Copy link
Collaborator

aklomp commented Sep 2, 2015

With the Travis error, it looks like one or both of the SMB_ constants is empty. It's strange because the code looks fine...

@aklomp
Copy link
Collaborator

aklomp commented Sep 2, 2015

Maybe try replacing the concatenation in LSeekTest.php with

sprintf("smb://%s/%s/lseektest.txt", SMB_HOST, SMB_SHARE);

@remicollet
Copy link
Contributor Author

Got it \o/

@remicollet remicollet closed this Sep 2, 2015
@aklomp
Copy link
Collaborator

aklomp commented Sep 2, 2015

Woah :) OK, I'll look into this pull request late this evening. Could you please quash your commits into a nice and small patchset?

@aklomp aklomp reopened this Sep 2, 2015
@remicollet remicollet closed this Sep 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants