fix: Improved handling of empty directories in get_dirs method #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Ever3tt, thank you so much for taking the time to send us improvements. According to my tests, is reached the main goal of this PR: if the theme from "THEME_OPTIONS" is not found, eox-theming uses first the theme defined in EOX_THEMING_DEFAULT_THEME_NAME ('bragi' in common.py or any other if is overridden), and, if none of these are found, uses the default theme from OpenEdx avoiding the app to get down. I think is a pretty appropriate change. Let me share this with my team and again thanks a lot |
|
@Ever3tt, can you sign your commit, please? |
|
@MaferMazu @bra-i-am it has just been signed :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@eduNEXT/dedalo @andrey-canon This PR wants to enhance the way in that the method works with null or empty values.
This is a previous used logic, which allows us to get specific values when they are available or to fall back to a default value in case there is no data, null, or empty data.