Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update integration tests workflow and add pytest configuration #221

Merged
merged 28 commits into from
Oct 22, 2024

Conversation

magajh
Copy link
Contributor

@magajh magajh commented Oct 14, 2024

Description

This PR includes some necessary changes to use the updated integration testing action https://github.com/eduNEXT/integration-test-in-tutor. The changes are described below:

  • Added pytest and pytest-django requirements to run the tests.
  • Updated the integration test workflow to use the updated action.
  • Modified the target in the Makefile to use pytest for running unit tests, ensuring consistency in how tests are executed across all plugins.
  • Added a target in the Makefile and a script to run the integration tests.
  • Moved integration tests for the backends and the info view to the integration folders.

For more information about the changes and the reasoning behind them, please refer to the documentation on writing integration tests for the plugins: https://internal.docs.edunext.co/en/latest/internal/Teams/Descontrol/Internal_processes/integration_tests_in_plugins/integration_tests_with_openedx_components.html

Note for Reviewers

This PR does not move the unit test files to unit/ folders. That effort will be part of a future PR when integration tests are added to the plugin.

How to Test

Ensure that both unit and integration tests pass without issues in the GitHub CI/CD pipeline.

@magajh magajh force-pushed the mjh/update-integration-tests-workflow branch from daac8ac to 292c269 Compare October 15, 2024 13:27
@magajh magajh changed the title Mjh/update integration tests workflow Refactor: update integration tests workflow and add pytest configuration Oct 16, 2024
@magajh magajh marked this pull request as ready for review October 16, 2024 10:06
@magajh magajh requested a review from a team as a code owner October 16, 2024 10:06
BryanttV
BryanttV previously approved these changes Oct 16, 2024
Copy link
Contributor

@BryanttV BryanttV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @magajh, LGTM! Just remember to update the branch of the integration tests action.

MaferMazu
MaferMazu previously approved these changes Oct 16, 2024
Copy link
Contributor

@MaferMazu MaferMazu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only comment here is we can use the main or release version of the integration test action. The rest looks good to me. Thanks ✨

@magajh magajh changed the title Refactor: update integration tests workflow and add pytest configuration refactor: update integration tests workflow and add pytest configuration Oct 17, 2024
@magajh magajh dismissed stale reviews from MaferMazu and BryanttV via f1bc45f October 17, 2024 12:38
@magajh
Copy link
Contributor Author

magajh commented Oct 17, 2024

@MaferMazu @BryanttV thank you both for the review! I've updated the action branch to main and removed the input

@magajh magajh force-pushed the mjh/update-integration-tests-workflow branch from f1bc45f to d9325c8 Compare October 22, 2024 12:47
@magajh magajh merged commit 86f68f8 into master Oct 22, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants