Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Make sysadmin dashboard tenant aware. #270

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

andrey-canon
Copy link

Description

The following modifications were applied

  • filter courses based on the course_org_filter value
  • Allow users with org staff role to perform actions

Before with staff user
image

Before with user with role
image

After with staff user and course_org_filter = ["edX"]
image

After with user with role and course_org_filter = ["test"]
image

Testing instructions

Please provide detailed step-by-step instructions for testing this change.

@johanseto
Copy link

johanseto commented Aug 25, 2022

Hi @andrey-canon I tested in my devstack local environment and is working given a user staff access role for org in courseaccesrole model.
2022-08-25_10-43
2022-08-25_10-43_1

The only thing was that to test is seems to be necessary the setting
FEATURES['ENABLE_SYSADMIN_DASHBOARD'] = True
In CMS and LMS corresponding env file settings (devstack.py and devstack.yml).
because on the contrary, the sysadmin URL will not work>
2022-08-25_10-27
Do you have also to configure this setting?

@andrey-canon andrey-canon merged commit 4469a58 into open-release/koa.nelp Aug 25, 2022
@andrey-canon andrey-canon deleted the and/make_sysadmin_tenant_aware branch October 7, 2022 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants