Adding autocomplete off to login form #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipemontoya
approved these changes
Oct 21, 2019
cocococosti
changed the base branch from
produhktiv/hawthorn+produhktiv
to
open-release/hawthorn.azure
cocococosti
changed the base branch from
open-release/hawthorn.azure
to
produhktiv/hawthorn+produhktiv
AuraAlba
approved these changes
Oct 21, 2019
cocococosti
force-pushed
the
coa/add-autocomplete-off
branch
from
0962d49
to
fbad0f5
Compare
cocococosti
changed the base branch from
produhktiv/hawthorn+produhktiv
to
open-release/hawthorn.produhktiv
morenol
approved these changes
Oct 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the report they sent (see ticket 7716), the
autocomplete offis not set in the login and registration forms, but open edx has the autocomplete off by default in the registration form.So, I think they expect the autocomplete off to be set also at the username and password fields. This is not as easy to do and may require JS.
I'm adding the autocomplete="off" to the entire form for now, but I don't think their security test will pass with only this change.