feat: sumac release #146
Open
feat: sumac release #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ian2012
approved these changes
Oct 29, 2024
Ian2012
reviewed
Oct 31, 2024
There was a problem hiding this comment.
Can we also take the chance to update some of the defaults if it makes sense? For example, the default value for DRYDOCK_INGRESS is false, but we almost always need it to be true, so it makes more sense to have it in true.
We could do a quick check of the default values for our variables and use the most common ones.
Co-authored-by: Cristhian Garcia <[email protected]>
|
I would change only DRYDOCK_INGRESS default value, the other ones seems good @MoisesGSalas |
Ian2012
reviewed
Nov 5, 2024
MoisesGSalas
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This intends to add support to sumac release from tutor.