Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(dev): rationalize translator for the 3 processes and store the locale value to redux only / remove inversify in renderer process / in class component split translator context and component refresh when locale updated / remove unused old class component #2592

Merged
merged 7 commits into from
Oct 15, 2024
Merged

chore(dev): rationalize translator for the 3 processes and store the locale value to redux only / remove inversify in renderer process / in class component split translator context and component refresh when locale updated / remove unused old class component #2592

merged 7 commits into from
Oct 15, 2024

Conversation

panaC
Copy link
Member

@panaC panaC commented Oct 5, 2024 •
edited
Loading

Fixes #2593
Closes #2490

@panaC panaC self-assigned this Oct 5, 2024
@danielweck
Copy link
Member

huge change set :)
what does this fix?

@panaC panaC changed the title chore(dev): translator refactoring chore(dev): rationalize translator for the 3 processes and store the locale value to redux only / remove invesify in renderer process / split the access to the translator context and the refresh component when locale updated Oct 5, 2024
@panaC panaC changed the title chore(dev): rationalize translator for the 3 processes and store the locale value to redux only / remove invesify in renderer process / split the access to the translator context and the refresh component when locale updated chore(dev): rationalize translator for the 3 processes and store the locale value to redux only / remove invesify in renderer process / in class componnent split translator context and component refresh when locale updated Oct 5, 2024
@panaC panaC changed the title chore(dev): rationalize translator for the 3 processes and store the locale value to redux only / remove invesify in renderer process / in class componnent split translator context and component refresh when locale updated chore(dev): rationalize translator for the 3 processes and store the locale value to redux only / remove inversify in renderer process / in class component split translator context and component refresh when locale updated Oct 5, 2024
@panaC panaC changed the title chore(dev): rationalize translator for the 3 processes and store the locale value to redux only / remove inversify in renderer process / in class component split translator context and component refresh when locale updated chore(dev): rationalize translator for the 3 processes and store the locale value to redux only / remove inversify in renderer process / in class component split translator context and component refresh when locale updated / remove unused old class component Oct 5, 2024
@panaC panaC marked this pull request as ready for review October 15, 2024 14:13
@panaC panaC merged commit 7a5cbc8 into develop Oct 15, 2024
7 checks passed
@panaC panaC deleted the chore/translator branch October 15, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@panaC panaC

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

initialize default app language with the preferred systems language
2 participants
@panaC @danielweck