Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated translations in XHTML. #1371

Merged
merged 2 commits into from
Feb 10, 2021
Merged

Updated translations in XHTML. #1371

merged 2 commits into from
Feb 10, 2021

Conversation

llemeurfr
Copy link
Contributor

The source is the English variant. Lithuanian and Chinese are direct ports of the .md files and could be humanly completed later. I added to the existing Japanese xhtml document a section about developers. Other files have been generated automatically via Deepl and may have to be cleaned-up later.

llemeurfr and others added 2 commits February 10, 2021 10:46
The source is the English variant. Lithuanian and Chinese are direct ports of the .md files and could be humanly completed later. I added to the existing Japanese xhtml document a section about developers. Other files have been generated automatically via Deepl and may have to be cleaned-up later.
…xt), formatted all XHTML files using VSCode defaults
@danielweck
Copy link
Member

Thank you Laurent. I used the online W3C / Nu validator ( https://validator.w3.org/#validate_by_input ) and found a couple of errors in the Spanish XHTML, which I corrected. I also applied consistent formatting using Visual Studio Code's default formatter.

@danielweck
Copy link
Member

danielweck commented Feb 10, 2021

I deleted the EDRLab.ThoriumReader folder on my MacOS laptop, to test each XHTML (automatically packaged in WebPub). I am getting this error:

A JavaScript error occurred in the main process

Uncaught Exception:
Error: ENOENT: no such file or directory, stat '/readium-desktop/dist/assets/md/information/undefined/en.xhtml'

Investigating...

@llemeurfr
Copy link
Contributor Author

I also used the nu formatter on most files (On some occasions, Deepl destroys some html tagging) but I must have left the Spanish one on the side. too bad.

@danielweck danielweck merged commit f31fc4c into develop Feb 10, 2021
@danielweck danielweck deleted the llm/xhtml-about branch February 10, 2021 10:33
@danielweck
Copy link
Member

Culprit commit: 1c03bd7

@cary-rowen
Copy link
Contributor

@danielweck Hello, I want to update the introduction of simplified Chinese, it is located at src\resources\information\zh-cn.xhtml Where should I find zh-cn.md Or should I create the file manually?

@panaC
Copy link
Member

panaC commented Feb 10, 2021

you can update this file : https://github.com/edrlab/thorium-reader/blob/develop/src/resources/information/zh-cn.xhtml.

  1. fork thorium
  2. create your branch
  3. update the xhtml file with your translation
  4. submit your branch with a PR

@llemeurfr
Copy link
Contributor Author

Hi @cary-rowen, zh-cn.md does not exist anymore (it is still in the history of the project but will not be used anymore). Updates must be made in zh-cn.xhtml. The first version of this xhtml file is simply a port of the markdown version in an xhtml structure. The English translation has been completed with more details; if you find the time to add these details, this is great; if not this is not urgent.

Thanks a lot for your help.

@cary-rowen
Copy link
Contributor

Hi @llemeurfr @panaC
Thanks for your reply, I still seem a little confused, I have the following questions:

  1. I found that "thorium-reader/src/resources/locales/zh-cn.json" contains many empty strings, do I need to start from this file if I want to contribute translations.
  2. If thorium-reader adds new translatable strings in the new version, how should I update it to Simplified Chinese, Need to run npm run i18n-check to get new translatable strings?
  3. I see that the maintainer of early simplified Chinese is @maitreya2019, I wonder if @maitreya2019 is still contributing translations.
  4. I found that "thorium-reader/src/resources/information/zh-cn.xhtml" is already translated in Chinese, but it looks more like machine translation.
  5. What should I do if I want to test my translation after translating, do I need to create a thorium-reader compilation environment locally?

My understanding: For Simplified Chinese I only need to translate the two files mentioned in (1) and (4), the former is the UI and the latter is the introduction information of the project, is that right?

Grateful

Cary

@danielweck
Copy link
Member

Discussion continued here: #1663

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants