Imp (types): Improved types for List data and it's meta #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e11sy
commented
Nov 6, 2024
e11sy
commented
- Improved Types
- Improved playground
neSpecc
reviewed
Nov 6, 2024
src/ListTabulator/index.ts
Outdated
| @@ -188,15 +188,15 @@ export default class ListTabulator<Renderer extends ListRenderer> { | |||
| /** | |||
| * Set start property value from initial data | |||
| */ | |||
| if (this.data.start !== undefined) { | |||
| this.changeStartWith(this.data.start); | |||
| if ((this.data.meta as OrderedListItemMeta).start !== undefined) { | |||
There was a problem hiding this comment.
Suggested change
| if ((this.data.meta as OrderedListItemMeta).start !== undefined) { | |
| if ('start' in this.data.meta) { |
Co-authored-by: Peter <[email protected]>
…ed-list into improve-item-meta
neSpecc
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.