Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/2.0 #104

Open
wants to merge 210 commits into
base: main
Choose a base branch
from
Open

Release/2.0 #104

wants to merge 210 commits into from

Conversation

e11sy
Copy link

@e11sy e11sy commented Nov 3, 2024

This PR is related to #75 issue
This PR is result of global work on List 2.0

Problems

  • Could not use List or Checklist data format for Nested List
  • Can not use cheklist as style of the nested list
  • Data model has no place for meta (e. g. checked field for checklist)
  • Nesting is not customizable
  • Can not start ordered list with custom variable
  • Can not change counters for ordered list
  • Can not split list on enter in the empty item in the midle of the list
  • Does not support backspace on the start of the first item
  • Nesting works unexpected sometimes
  • One file architecture
  • Shortcut fails to make defaultStyle effective
  • defaultStyle is not respected by toolbox

Solutions

  • Implement checklist as style of the nested list
  • Support new data model with meta attribute for each item:
interface ListItem {
  content: string;

  meta: OrderedListMeta | UnorderedListMeta | ChecklistMeta;      // meta should depend on list type
  
  items: ListItem[];
}
  • Separate List rendering and tabulation (rendered should render items and wrappers dependant on list style), tabulator should handle keydowns and work with editor events
  • Rerender list, when style changed
  • Export all list styles to toolbox
  • Implement data converter from old List and Checklist formats to new Nested List
  • Support nesting customisation by maxLevel config option
  • Support <ol> attributes, in config (such as type, start)

Status

resolves #11
resolves #15
resolves #27
resolves #28
resolves #30
resolves #32
resolves #43
resolves #66
resolves #70
resolves #75
resolves #80
resolves #87

e11sy and others added 30 commits November 2, 2024 21:48
Chore (readme): Updated readme
Chore (config): move maxLevel from data to config
Feat (data): support checklist data format
fix (build): update packages to fix build
Chore (): rename Nested List tool to the Editorjs List tool
Co-authored-by: Peter <[email protected]>
Fix (readme): remove redundant lines
Imp (types): Improved types for List data and it's meta
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment