-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: auto-create the link block when a non-image link is pasted #83
Open
antoineol
wants to merge
22
commits into
editor-js:master
Choose a base branch
from
graphcomment:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a URL is pasted and a link block created, it automatically opens the block settings, to show the user they can remove the preview.
Вся ваша проблема решается , следующим куском кода
|
feat(videoLinks): prevent embed link on videos
chore(embedLink): new Layout
Will this ever be merged or should I also fork the project and make my own version of it? |
feat(index.css): highlightedEmbed
hotfix(index.css): fix flex direction when highlighted
hotfix(index.css): fix missing closing block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is a feature I need for my project, and I thought it would be good to suggest a merge in the main repo.
Use case: when users paste links in the editor, in an empty paragraph, it should automatically attempt to create a link block.
It may introduce a couple of UX issues, so I also changed:
Improvements I've identified, but I don't know how to do them:
If you have any suggestions for them, I would be happy to improve the code.