fix: HTML5 tech with audio tag shouldn't use requestVideoFrameCallback (

videojs#7778)
edirub · Jun 8, 2023 · 1884040 · 1884040
1 parent 74e5e34
commit 1884040
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/src/js/tech/html5.js b/src/js/tech/html5.js
@@ -114,6 +114,8 @@ class Html5 extends Tech {
     // into a `fullscreenchange` event
     this.proxyWebkitFullscreen_();
 
+    this.featuresVideoFrameCallback = this.featuresVideoFrameCallback && this.el_.tagName === 'VIDEO';
+
     this.triggerReady();
   }
 

diff --git a/test/unit/tech/html5.test.js b/test/unit/tech/html5.test.js
@@ -1032,3 +1032,12 @@ QUnit.test('supports getting available media playback quality metrics', function
   window.performance = origPerformance;
   window.Date = origDate;
 });
+
+QUnit.test('featuresVideoFrameCallback is false for audio elements', function(assert) {
+  const el = document.createElement('audio');
+  const audioTech = new Html5({el});
+
+  assert.strictEqual(audioTech.featuresVideoFrameCallback, false, 'Html5 with audio element should not support rvf');
+
+  audioTech.dispose();
+});