Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CheckIdentityKeyExists was comparing to constant #192

Merged
merged 1 commit into from
Mar 7, 2023
Merged

fix: CheckIdentityKeyExists was comparing to constant #192

merged 1 commit into from
Mar 7, 2023

Conversation

bnevis-i
Copy link
Collaborator

@bnevis-i bnevis-i commented Mar 7, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

make test

New Dependency Instructions (If applicable)

@bnevis-i bnevis-i requested a review from chr1shung March 7, 2023 15:34
@bnevis-i bnevis-i added this to the Minnesota milestone Mar 7, 2023
Copy link

@chr1shung chr1shung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #192 (f07b63b) into main (9c30f8a) will increase coverage by 1.24%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #192      +/-   ##
==========================================
+ Coverage   69.47%   70.71%   +1.24%     
==========================================
  Files          18       18              
  Lines        1284     1284              
==========================================
+ Hits          892      908      +16     
+ Misses        308      290      -18     
- Partials       84       86       +2     
Impacted Files Coverage Δ
internal/pkg/vault/management.go 67.00% <100.00%> (+4.06%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bnevis-i bnevis-i requested a review from jim-wang-intel March 7, 2023 15:49
@bnevis-i bnevis-i merged commit 3201b0f into edgexfoundry:main Mar 7, 2023
@bnevis-i bnevis-i deleted the fix-check-identity-exists branch March 7, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants