Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Updated logic to process vault response for GetKeys #162

Merged
merged 9 commits into from
Sep 15, 2022

Conversation

drkfmorton
Copy link
Contributor

@drkfmorton drkfmorton commented Sep 15, 2022

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-secrets/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

New Dependency Instructions (If applicable)

@codecov-commenter
Copy link

Codecov Report

Merging #162 (8096f46) into main (46e806f) will decrease coverage by 0.02%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main     #162      +/-   ##
==========================================
- Coverage   77.57%   77.55%   -0.03%     
==========================================
  Files          17       17              
  Lines         941      940       -1     
==========================================
- Hits          730      729       -1     
  Misses        150      150              
  Partials       61       61              
Impacted Files Coverage Δ
internal/pkg/vault/secrets.go 74.90% <83.33%> (-0.10%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but PR title needs to be corrected.

@drkfmorton drkfmorton changed the title Feat 348 Feat 348: Update to getAllPaths functionality Sep 15, 2022
@lenny-goodell lenny-goodell changed the title Feat 348: Update to getAllPaths functionality feat: Update to getAllPaths functionality Sep 15, 2022
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@lenny-goodell lenny-goodell changed the title feat: Update to getAllPaths functionality fix: Updated logic to process vault response for GetKeys Sep 15, 2022
@lenny-goodell lenny-goodell merged commit 7064924 into edgexfoundry:main Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants