-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Updated logic to process vault response for GetKeys #162
Conversation
Signed-off-by: Kyle Morton <[email protected]>
Signed-off-by: Kyle Morton <[email protected]>
Signed-off-by: Kyle Morton <[email protected]>
Signed-off-by: Kyle Morton <[email protected]>
Signed-off-by: Kyle Morton <[email protected]>
Signed-off-by: Kyle Morton <[email protected]>
Signed-off-by: Kyle Morton <[email protected]>
Signed-off-by: Kyle Morton <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #162 +/- ##
==========================================
- Coverage 77.57% 77.55% -0.03%
==========================================
Files 17 17
Lines 941 940 -1
==========================================
- Hits 730 729 -1
Misses 150 150
Partials 61 61
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, but PR title needs to be corrected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-secrets/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Testing Instructions
New Dependency Instructions (If applicable)