Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: close response Body when the returned error is nil (#146) #152

Merged
merged 1 commit into from
Jun 1, 2022
Merged

fix: close response Body when the returned error is nil (#146) #152

merged 1 commit into from
Jun 1, 2022

Conversation

bnevis-i
Copy link
Collaborator

@bnevis-i bnevis-i commented Jun 1, 2022

  • fix: close response Body when the returned error is nil

Signed-off-by: gao270615179 [email protected]

  • fix: add InMemoryMockCaller response body

Signed-off-by: gao270615179 [email protected]

Cherry pick 3ba02e4 from main

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

make test

New Dependency Instructions (If applicable)

@jlikeme @bnevis-i
fix: close response Body when the returned error is nil (#146)
b0d0256 
* fix: close response Body when the returned error is nil

Signed-off-by: gao270615179 <[email protected]>

* fix: add InMemoryMockCaller response body

Signed-off-by: gao270615179 <[email protected]>
@bnevis-i bnevis-i requested a review from lenny-goodell June 1, 2022 16:46
@bnevis-i bnevis-i added this to the Jakarta milestone Jun 1, 2022
@bnevis-i bnevis-i linked an issue Jun 1, 2022 that may be closed by this pull request
resp.Body is not closed after return 404 #145
Closed
lenny-goodell
lenny-goodell approved these changes Jun 1, 2022
View reviewed changes
Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bnevis-i bnevis-i merged commit 9196965 into edgexfoundry:jakarta Jun 1, 2022
@bnevis-i bnevis-i deleted the bnevis-i/issue-145 branch June 1, 2022 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lenny-goodell lenny-goodell lenny-goodell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Jakarta
Development

Successfully merging this pull request may close these issues.

resp.Body is not closed after return 404
3 participants
@bnevis-i @lenny-goodell @jlikeme