feat: Enabling hooks for Vault identity features #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #171 +/- ##
==========================================
- Coverage 77.42% 72.33% -5.10%
==========================================
Files 18 18
Lines 988 1236 +248
==========================================
+ Hits 765 894 +129
- Misses 162 265 +103
- Partials 61 77 +16
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This set of changes enables secret store tokens to be identity-based. This change only add new methods to the secret store interfaces and implementions and does not modify existing functionality. Instead of issuing anonymous Vault tokens with attached policy. This commit adds additional methods to create Vault-based identities and authenticate to these identities using programmable auth methods. This is important step to "deprivilege" Vault usage, as creating raw tokens requires "sudo" ability in Vault, whereas identity auth is a user operation. Additionally, vault-based identity can be attested (as a JWT) and verified. Signed-off-by: Bryon Nevis <[email protected]>
|
@jim-wang-intel, @lenny-intel. This one ready for review and merge. |
chr1shung
reviewed
Mar 7, 2023
| } | ||
|
|
||
| for _, v := range response.Data.Keys { | ||
| if v == "keyName" { |
There was a problem hiding this comment.
Good catch! Fixed in #192
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This set of changes enables secret store tokens to be identity-based.
Instead of issuing anonymous Vault tokens with attached policy,
this commit adds additional methods to create Vault-based
identities and authenticate to these identities using
programmable auth methods. This is important step to "deprivilege"
Vault usage, as creating raw tokens requires "sudo" ability in Vault,
whereas identity auth is a user operation. Additionally,
vault-based identity can be attested (as a JWT) and verified.
Signed-off-by: Bryon Nevis [email protected]
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-secrets/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)Testing Instructions
New Dependency Instructions (If applicable)