refactor: moving consul access and role interface #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #163 +/- ##
==========================================
- Coverage 77.55% 77.42% -0.13%
==========================================
Files 17 18 +1
Lines 940 988 +48
==========================================
+ Hits 729 765 +36
- Misses 150 162 +12
Partials 61 61
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
bnevis-i
previously approved these changes
Oct 12, 2022
1 task
jim-wang-intel
previously approved these changes
Oct 12, 2022
|
lenny-goodell
requested changes
Oct 18, 2022
|
Updated all references of registry to consul |
lenny-goodell
approved these changes
Oct 19, 2022
Moving configureConsulAccess and createRole to go-mod-secrets to consolidate consul API. Closes: #3227 Signed-off-by: Rico Chavez-Lopez <[email protected]>
bnevis-i
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving configureConsulAccess and createRole to go-mod-secrets to consolidate consul API.
Closes: #3227
Signed-off-by: Rico Chavez-Lopez [email protected]
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-secrets/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)Testing Instructions
Please refer to edgexfoundry/edgex-go#4193
New Dependency Instructions (If applicable)