refactor: moving consul access and role interface

[ItsRico]

Moving configureConsulAccess and createRole to go-mod-secrets to consolidate consul API.

Closes: #3227

Signed-off-by: Rico Chavez-Lopez [email protected]

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

• [ x] I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
• [x ] I am not introducing a new dependency (add notes below if you are)
• [x ] I have added unit tests for the new feature or bug fix (if not, why?)
• [ x] I have fully tested (add details below) this the new feature or bug fix (if not, why?)
• I have opened a PR for the related docs change (if not, why?)

Testing Instructions

https://github.com/ItsRico/edgex-go/tree/3227-testing
To test these changes,

1. Checkout this branch
2. Checkout refactor: moving consul access and role interface go-mod-secrets#163 in a subfolder of this branch
3. The following two steps can be viewed here: https://github.com/ItsRico/edgex-go/compare/main...ItsRico:edgex-go:3227-testing?expand=1
4. Update your go.mod file using the replace directive. ( => ./go-mod-secrets)
5. Update your Makefile to copy go-mod-secrets (add a COPY to the inline Dockerfile)
   In edgex-go, run
6. make test
7. make clean
8. make clean_docker_base
9. make docker_base
10. make dev
11. Then, in your edgex-compose/compose-builder/ folder,
12. make run dev

The unit tests for these changes can be found in aclroles_test.go and in go-mod-secrets's management_test.go.

[jim-wang-intel]

still some questions and should refactor more.

[ItsRico]

• removed aclroles_test.go

Still need to add helper function for client creation and remove from loop

[ItsRico]

• Updated reference to NewRegistryRole to NewConsulRole, reflecting corresponding changes in go-mod-secrets
• Moved client creation outside of for loop for CreateRole
• Reran Testing Instructions

[lenny-goodell]

LGTM

[lenny-goodell]

@ItsRico , you will need to rebase and resolve the conflicts in internal/security/bootstrapper/command/setupacl/aclpolicies.go

[ItsRico]

Had an issue with the rebase, need to try again

[jim-wang-intel]

LGTM

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

No Coverage information
0.0% Duplication

[lenny-goodell]

LGTM