Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Redis Pub/Sub depencency #366

Closed
judehung opened this issue Nov 5, 2024 · 0 comments · Fixed by #367
Closed

Remove Redis Pub/Sub depencency #366

judehung opened this issue Nov 5, 2024 · 0 comments · Fixed by #367
Assignees
Labels
enhancement New feature or request

Comments

@judehung
Copy link
Member

judehung commented Nov 5, 2024

🚀 Feature Request

Relevant Package [REQUIRED]

This feature request is for all edgex services which utilize go-mod-messaging.

Description [REQUIRED]

Since Redis Pub/Sub will be no longer supported in EdgeX v4.0, remove its dependency out of go-mod-messaging.
@judehung judehung added the enhancement New feature or request label Nov 5, 2024
@judehung judehung self-assigned this Nov 5, 2024
judehung added a commit to judehung/go-mod-messaging that referenced this issue Nov 5, 2024
judehung added a commit to judehung/go-mod-bootstrap that referenced this issue Nov 7, 2024
Per edgexfoundry/go-mod-messaging#366,
EdgeX remove support on Redis Pub/Sub as message bus, so unit tests
related to redis pub/sub should be removed as well to avoid errors.

Notr that redis pub/sub doesn't need to establish preemptive connection
before publish and subscribe, and a redis client can be susccessfully
created and make noop Connect() without error per the implmentation of
removed unit tests.

Signed-off-by: Jude Hung <[email protected]>
cloudxxx8 pushed a commit to edgexfoundry/go-mod-bootstrap that referenced this issue Nov 7, 2024
* fix: remove unit tests related to redis pub/sub

Per edgexfoundry/go-mod-messaging#366,
EdgeX remove support on Redis Pub/Sub as message bus, so unit tests
related to redis pub/sub should be removed as well to avoid errors.

Notr that redis pub/sub doesn't need to establish preemptive connection
before publish and subscribe, and a redis client can be susccessfully
created and make noop Connect() without error per the implmentation of
removed unit tests.

Signed-off-by: Jude Hung <[email protected]>

* fix: Update the secretName from redis to other meaningful naming

Signed-off-by: Jude Hung <[email protected]>

---------

Signed-off-by: Jude Hung <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant