feat!: Remove Notify out of Device DTO/Model #807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: remove Notify out of Device DTO/Model The current Device model/DTO contains a boolean filed `notify`. When notify is set to true, the device service managing the device will receive a notification. Since core-metadata will publish system event message when device is created or updated, this notify is no longer needed and should be removed. fixes edgexfoundry#805 Signed-off-by: Jude Hung <[email protected]>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #807 +/- ##
==========================================
+ Coverage 64.46% 64.49% +0.03%
==========================================
Files 80 80
Lines 3079 3076 -3
==========================================
- Hits 1985 1984 -1
+ Misses 905 904 -1
+ Partials 189 188 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
judehung
added a commit
to judehung/edgex-go
that referenced
this pull request
Feb 21, 2023
field into ProvisionWatcher dto BREAKING CHANGE: Remove Notify field out of Device model/dto Per edgexfoundry/go-mod-core-contracts#807, the boolean field notify of Device DTO is removed as device creation notification is handled by system event message now. This commit updates following material to reflect such changes: 1. update go.mod/go.sum to use v3.0.0-dev.20 2. update swagger file correspondingly (remove notify field out of Device dto and add properties field into ProvisionWatcher dto) 3. update unit test correspondingly Signed-off-by: Jude Hung <[email protected]>
judehung
added a commit
to judehung/edgex-docs
that referenced
this pull request
Feb 22, 2023
Per edgexfoundry/edgex-go#4375 and edgexfoundry/go-mod-core-contracts#807, the notify field of Device DTO is removed, so that documentation should be updated to remove the notify field as well. Signed-off-by: Jude Hung <[email protected]>
judehung
added a commit
to judehung/edgex-docs
that referenced
this pull request
Feb 22, 2023
Per edgexfoundry/edgex-go#4375 and edgexfoundry/go-mod-core-contracts#807, the notify field of Device DTO is removed, so that documentation should be updated to remove the notify field as well. Signed-off-by: Jude Hung <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: remove Notify out of Device DTO/Model
The current Device model/DTO contains a boolean filed
notify. When notify is set to true, the device service managing the device will receive a notification. Since core-metadata will publish system event message when device is created or updated, this notify is no longer needed and should be removed.fixes #805
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/go-mod-core-contracts/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:describing the break)Testing Instructions
New Dependency Instructions (If applicable)