Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EdgeX 3.0] Use true/false instead of yes/no in query parameters #780

Closed
cloudxxx8 opened this issue Dec 9, 2022 · 0 comments · Fixed by #782
Closed

[EdgeX 3.0] Use true/false instead of yes/no in query parameters #780

cloudxxx8 opened this issue Dec 9, 2022 · 0 comments · Fixed by #782
Assignees
@jinlinGuan
Labels
enhancement New feature or request

Comments

@cloudxxx8
Copy link
Member

🚀 Feature Request

Relevant Package [REQUIRED]

This feature request is for core-command

Description [REQUIRED]

We are using common.ValueYes and common.ValueNo for some query parameters, and we should use true and false for consistency.

Describe the solution you'd like

Remove common.ValueYes and common.ValueNo, and change the code to use common.ValueTrue and common.ValueFalse
@cloudxxx8 cloudxxx8 added the enhancement New feature or request label Dec 9, 2022
@cloudxxx8 cloudxxx8 moved this to New Issues in Technical WG Dec 9, 2022
@cloudxxx8 cloudxxx8 moved this from New Issues to Release Backlog in Technical WG Dec 9, 2022
jinlinGuan added a commit to jinlinGuan/go-mod-core-contracts that referenced this issue Dec 23, 2022
@jinlinGuan
refactor!: Use true/false for command parameters to be more consistent
946c974 
BREAKING CHANGE:
- ds-pushevent and ds-returnevent to use true/false instead of yes/no

close edgexfoundry#780

Signed-off-by: Ginny Guan <[email protected]>
@jinlinGuan jinlinGuan mentioned this issue Dec 23, 2022
Merged
5 tasks
jinlinGuan added a commit to jinlinGuan/go-mod-core-contracts that referenced this issue Jan 11, 2023
@jinlinGuan
refactor!: Use true/false for command parameters to be more consistent
a2a49d7 
BREAKING CHANGE: ds-pushevent and ds-returnevent to use true/false instead of yes/no

close edgexfoundry#780

Signed-off-by: Ginny Guan <[email protected]>
@github-project-automation github-project-automation bot moved this from Release Backlog to Minnesota Done in Technical WG Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jinlinGuan jinlinGuan

Labels
enhancement New feature or request
Projects
Technical WG
Archived in project
Milestone
No milestone
2 participants
@cloudxxx8 @jinlinGuan